Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use doc link service instead of ElasticDocsLink #109027

Merged
merged 3 commits into from
Sep 1, 2021
Merged

[APM] Use doc link service instead of ElasticDocsLink #109027

merged 3 commits into from
Sep 1, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 18, 2021 •
edited
Loading

Summary

Related to #88107
This PR replaces the need for https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/shared/Links/ElasticDocsLink.tsx in the service map component the APM app. Instead, it uses the https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts, which is checked as part of the documentation builds.

@lcawl lcawl added apm:service-maps Service Map feature in APM v7.16.0 v8.0.0 labels Aug 18, 2021
@lcawl lcawl mentioned this pull request Aug 18, 2021
Closed
@lcawl lcawl marked this pull request as ready for review August 26, 2021 00:48
@lcawl lcawl requested review from a team as code owners August 26, 2021 00:48
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@lcawl
Copy link
Contributor Author

lcawl commented Aug 30, 2021

@elasticmachine merge upstream

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Aug 30, 2021
@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv
Copy link
Member

sorenlouv commented Aug 31, 2021 •
edited
Loading

Looks like a canvas storybook is causing the storybook check to fail:

[2021-08-30T19:29:18.852Z]   console.error
[2021-08-30T19:29:18.852Z]     Warning: Failed prop type: Invalid prop `shapes` of type `array` supplied to `ShapePicker`, expected `object`.
[2021-08-30T19:29:18.852Z]         in ShapePicker (created by storyFn)
[2021-08-30T19:29:18.852Z]         in storyFn
[2021-08-30T19:29:18.852Z] 
[2021-08-30T19:29:18.852Z]       13 |
[2021-08-30T19:29:18.852Z]       14 | storiesOf('components/Shapes/ShapePicker', module).add('default', () => (
[2021-08-30T19:29:18.852Z]     > 15 |   <ShapePicker shapes={getAvailableShapes()} onChange={action('onChange')} />
[2021-08-30T19:29:18.852Z]          |   ^
[2021-08-30T19:29:18.852Z]       16 | ));
[2021-08-30T19:29:18.852Z]       17 |
[2021-08-30T19:29:18.852Z] 
[2021-08-30T19:29:18.852Z]       at printWarning (node_modules/prop-types/checkPropTypes.js:20:15)
[2021-08-30T19:29:18.852Z]       at checkPropTypes (node_modules/prop-types/checkPropTypes.js:82:11)
[2021-08-30T19:29:18.852Z]       at validatePropTypes (node_modules/react/cjs/react.development.js:1875:5)
[2021-08-30T19:29:18.852Z]       at Object.createElementWithValidation [as createElement] (node_modules/react/cjs/react.development.js:2059:5)
[2021-08-30T19:29:18.852Z]       at x-pack/plugins/canvas/public/components/shape_picker/__stories__/shape_picker.stories.tsx:15:3
[2021-08-30T19:29:18.852Z]       at finalStoryFn (node_modules/@storybook/client-api/dist/story_store.js:632:32)
[2021-08-30T19:29:18.852Z]       at node_modules/@storybook/addons/dist/hooks.js:247:21

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB +142.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 417.7KB 417.8KB +139.0B

History

  • 💚 Build #150012 succeeded 360a6895b7d6a65ae5299c9adc18abb1f4f73e3a
  • 💔 Build #149707 failed dd7b281ae0fe7c14e71aeea976adf4ed25085618
  • 💔 Build #149560 failed 681b77f318e55ab7c455066746a9151094d5d958
  • 💔 Build #146809 failed e9fb9bc0373f4d31d6d058676683f7053e982930
  • 💔 Build #146762 failed c8651f586e32a4d13740dbc39618973f885a9785

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 714735d into elastic:master Sep 1, 2021
@lcawl lcawl deleted the apm-links2 branch September 1, 2021 19:14
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 1, 2021
@lcawl
[APM] Use doc link service instead of ElasticDocsLink (elastic#109027)
c8cea1b
@lcawl lcawl mentioned this pull request Sep 1, 2021
Merged
lcawl added a commit that referenced this pull request Sep 1, 2021
@lcawl
[APM] Use doc link service instead of ElasticDocsLink (#109027) (#110873
7b30aec 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
apm:service-maps Service Map feature in APM release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @elasticmachine @sorenlouv @kibanamachine @mshustov